-
Notifications
You must be signed in to change notification settings - Fork 253
Bugfix: Sorting and searching throw a view with error message on Campaigns view #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
milosz-w-rigby
wants to merge
20
commits into
fix/mm2-1458
Choose a base branch
from
MM2-1403-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
base: fix/mm2-1458
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add price preferences vendor endpoint * fix: oas tags * fix: events * version: bump to medusa 2.8.6 (#332) * fix: enable setting up shipping option price with region * fix: use also for update * fix: seller invitation email * fix: return order display id with order sets * implement no talkjs app key screen (#349) * mode fix * mode fix * talkjs app id request (#353) * fix: invitation links & token * fix: returns process * fix: seller details admin panel (#357) * fix: add reason id * fix: auth middleware * fix: return request status changed despite the error * add s3 storage * remove s3 * fix conflicts * feat(attribute): add is_required field to attribute model * feat(attribute): add is_required field to UpdateAttributeDTO and CreateAttributeDTO interfaces * feat(attribute): add is_required field to AttributeDTO interface * feat(attribute): add is_required field to API documentation for attributes * feat(attribute): add is_filterable and is_required fields to attribute validation schemas * feat(attribute): add is_required field to defaultAdminAttributeFields in query config * feat(attribute): enhance AttributeForm with is_required field and update labels for optional fields * feat(attribute): add is_filterable and is_required columns to attribute table with conditional rendering * fix(attribute): update import path for Attribute types and modify query key usage in useAttributes hook * fix(attribute): update import path for AttributeDTO to use @mercurjs/framework * feat(migration): add migration to include is_required column in attribute table * refactor(attribute): update useAttributes and useAttribute hooks to improve type definitions and query key handling * feat(attribute): enhance attribute table columns with edit, delete, and toggle functionalities * feat(attribute): implement client-side filtering and sorting for attributes table with enhanced UI components * feat(attribute): update sorting options in attributes table to include created_at and updated_at fields * feat(attribute): expand attribute details to include ui_component, is_filterable, and is_required fields * feat(attribute): enhance edit attribute page with progress tabs and improved save functionality * feat(attribute): add form state management and tab navigation for attribute creation and editing * feat(attribute): add CategorySelectionModal component for selecting product categories in attribute management * feat(attribute): implement progress tabs and update save button for attribute creation page * fix(MultiSelectCategory): update selected item indicator color * feat(PossibleValuesList): update UI components and improve layout for better usability * refactor(PossibleValuesList): remove unused icon import to streamline component * feat(attribute): add is_global field to attribute validators and enforce category assignment rules * feat(attribute): add is_global field and created_at/updated_at timestamps to AttributeDTO * feat(attribute): add is_global field to UpdateAttributeDTO and CreateAttributeDTO interfaces * feat(migration): add is_global column to attribute table with migration script * feat(migration): create migration script to add is_global column to attribute table * feat(attribute): add is_global field to Attribute model * fix(AttributeForm): simplify ui_component assignment and improve conditional rendering for PossibleValuesList * refactor(AttributeForm): remove is_global field and update category section visibility logic * refactor(AttributeForm): reposition warning message for improved visibility and conditional rendering * feat(EditAttributePage): include is_required field in attribute fields for correct data handling * refactor(attribute): remove is_global field from AttributeDTO and related interfaces, and create migration to drop the column from the database * feat(AttributeForm, EditAttributePage, CreateAttributePage): implement form reference handling and update button actions for improved navigation and submission (#399) * feat(AttributeForm): implement custom validation for category selecti… (#400) * feat(AttributeForm): implement custom validation for category selection and update error handling with Hint component * feat(MultiSelectCategory): enhance badge visibility logic and implement dynamic badge count based on available width * Mm2 1074 admin attributes when more than 10 attributes is selected bottom of modal is not visible (#401) * refactor(EditAttributePage, CreateAttributePage): restructure modal layout for improved, scrollable UI * fix(AttributeForm, EditAttributePage, CreateAttributePage): updatecategory validation logic and integrate into form submission process * Mm2 1075 admin attributes possible values issues (#402) * feat(AttributeDetailPage): enhance dropdown menu with icons for edit and delete actions * feat(PossibleValuesTable): add delete confirmation prompt and update possible values handling * fix(EditPossibleValuePage): update metadata handling to use undefined instead of null * refactor(EditPossibleValuePage): comment out MetadataEditor component for possible future implementation * fix(MultiSelectCategory): adjust badge width calculation for improved visibility * Merge main into testing via checkout * feat/mm2-1378 admin panel cleanup * ver: update package.json versions * update changelog (#430) * update changelog * update changelog, add contributors * fix: creating seller after accept of request from admin --------- Co-authored-by: slusarczykmichal <[email protected]> Co-authored-by: slusarczykmichal <[email protected]> Co-authored-by: Paweł Fulara <[email protected]> Co-authored-by: pfulara <[email protected]> Co-authored-by: katPanek <[email protected]> Co-authored-by: itariv <[email protected]> Co-authored-by: Mikolaj Borowski <[email protected]> Co-authored-by: rigbyms <[email protected]>
* fix: old migration * feat: create fix database script * ver: update versions
…-product-in-vendor-panel-is-not-visible-on-storefront chore: deleted incorrect relation info request
…th-regions chore: revert of backend changes for aloglia indexes products info
Clear build command for testing
…03-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
…-a-view-with-error-message-on-campaigns-view' of github.com:mercurjs/mercur into MM2-1403-b-2-c-vendor-panel-sorting-and-searching-throw-a-view-with-error-message-on-campaigns-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://rigbysoftwarehouse.atlassian.net/browse/MM2-1403?atlOrigin=eyJpIjoiZWQ2ODc0YjE1Mzc4NDFjMjlhMmMwYWU2MjczYThmYzAiLCJwIjoiaiJ9
added index on /vendors/campaigns instead of graph + q parameter